-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tf default ec_deployment deployment_template #11438
Merged
carsonip
merged 6 commits into
elastic:main
from
carsonip:benchmark-note-apm-server-size
Aug 22, 2023
Merged
Update tf default ec_deployment deployment_template #11438
carsonip
merged 6 commits into
elastic:main
from
carsonip:benchmark-note-apm-server-size
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request does not have a backport label. Could you fix it @carsonip? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
Skip notification from the automated backport with mergify
label
Aug 21, 2023
lahsivjar
approved these changes
Aug 21, 2023
kruskall
reviewed
Aug 21, 2023
carsonip
changed the title
Update benchmark tf note about >8gb apm server size
Update benchmark tf default deployment template
Aug 21, 2023
carsonip
changed the title
Update benchmark tf default deployment template
Update tf default GCP deployment template
Aug 21, 2023
carsonip
changed the title
Update tf default GCP deployment template
Update tf default ec_deployment deployment_template
Aug 21, 2023
kruskall
approved these changes
Aug 21, 2023
bmorelli25
pushed a commit
to bmorelli25/apm-server
that referenced
this pull request
Sep 5, 2023
Update all tf ec_deployment default deployment_template. Particularly useful for benchmarking on GCP because now it is possible to go over 8gb per apm server in GCP. Update note in benchmark tf file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Update all tf ec_deployment default deployment_template. Particularly useful for benchmarking on GCP because now it is possible to go over 8gb per apm server in GCP. Update note in benchmark tf file.
Checklist
apmpackage
have been made)For functional changes, consider:
How to test these changes
Related issues