Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tf default ec_deployment deployment_template #11438

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Update tf default ec_deployment deployment_template #11438

merged 6 commits into from
Aug 22, 2023

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Aug 21, 2023 •
edited
Loading

Motivation/summary

Update all tf ec_deployment default deployment_template. Particularly useful for benchmarking on GCP because now it is possible to go over 8gb per apm server in GCP. Update note in benchmark tf file.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@carsonip carsonip requested a review from a team as a code owner August 21, 2023 08:46
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 21, 2023
@carsonip carsonip changed the title Update benchmark tf note about >8gb apm server size Update benchmark tf default deployment template Aug 21, 2023
@carsonip carsonip requested a review from kruskall August 21, 2023 10:37
@carsonip carsonip changed the title Update benchmark tf default deployment template Update tf default GCP deployment template Aug 21, 2023
@carsonip carsonip changed the title Update tf default GCP deployment template Update tf default ec_deployment deployment_template Aug 21, 2023
@carsonip carsonip enabled auto-merge (squash) August 21, 2023 12:19
@carsonip carsonip merged commit 5dbd451 into elastic:main Aug 22, 2023
11 checks passed
bmorelli25 pushed a commit to bmorelli25/apm-server that referenced this pull request Sep 5, 2023
@carsonip @bmorelli25
Update tf default ec_deployment deployment_template (elastic#11438)
0c87f84 
Update all tf ec_deployment default deployment_template. Particularly useful for benchmarking on GCP because now it is possible to go over 8gb per apm server in GCP. Update note in benchmark tf file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahsivjar lahsivjar lahsivjar approved these changes

@kruskall kruskall kruskall approved these changes

Assignees
No one assigned
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carsonip @lahsivjar @kruskall